Add php-cs-fixer to the CI

bigcommerce · Jan 10, 2024 · 066906f · 066906f
1 parent 64ecfd2
commit 066906f
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 20 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -12,6 +12,14 @@ jobs_default: &jobs_default
  parameters:
  php-version: [ "8.1", "8.2" ]
 
+jobs:
+ cs-fixer:
+ executor:
+ name: php/php
+ steps:
+ - ci/pre-setup
+ - php/composer-install
+ - run: ./vendor/bin/php-cs-fixer fix --diff --dry-run -v
 
 workflows:
  version: 2
@@ -23,3 +31,4 @@ workflows:
  - php/static-analysis:
  <<: *jobs_default
  generate_ide_helper: false
+ - cs-fixer
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -0,0 +1,12 @@
+<?php
+ return (new PhpCsFixer\Config())
+ ->setFinder(
+ PhpCsFixer\Finder::create()
+ ->files()
+ ->in(__DIR__)
+ ->name("*.php")
+ ->ignoreVCSIgnored(true)
+ )
+ ->setRules([
+ '@PSR2' => true,
+ ]);
diff --git a/.php_cs.dist b/.php_cs.dist
diff --git a/rector.php b/rector.php
@@ -8,7 +8,7 @@
 use Rector\Set\ValueObject\LevelSetList;
 
 return static function (RectorConfig $rectorConfig): void {
- $rectorConfig->paths([__DIR__ . '/test',]);
+ $rectorConfig->paths([__DIR__ . '/test']);
  $rectorConfig->sets([
  PHPUnitSetList::PHPUNIT_100
  ]);

diff --git a/test/Unit/Api/ClientTest.php b/test/Unit/Api/ClientTest.php
@@ -55,10 +55,10 @@ public function testFailOnErrorPassesThroughToConnection()
  {
  $matcher = $this->exactly(2);
  $this->connection->expects($matcher)
- ->method('failOnError')->willReturnCallback(fn() => match ($matcher->numberOfInvocations()) {
- 1 => [true],
- 2 => [false],
- });
+ ->method('failOnError')->willReturnCallback(fn () => match ($matcher->numberOfInvocations()) {
+  1 => [true],
+  2 => [false],
+  });
  Client::failOnError(true);
  Client::failOnError(false);
  }
@@ -75,10 +75,10 @@ public function testVerifyPeerPassesThroughToConnection()
  {
  $matcher = $this->exactly(2);
  $this->connection->expects($matcher)
- ->method('verifyPeer')->willReturnCallback(fn() => match ($matcher->numberOfInvocations()) {
- 1 => [true],
- 2 => [false],
- });
+ ->method('verifyPeer')->willReturnCallback(fn () => match ($matcher->numberOfInvocations()) {
+  1 => [true],
+  2 => [false],
+  });
  Client::verifyPeer(true);
  Client::verifyPeer(false);
  }