APPEX-243: adds case-insensitive handling for HTTP header titles #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-zachary
commented
Feb 9, 2022
| @@ -6,7 +6,7 @@ AllCops: | |||
| - vendor/**/* | |||
| - examples/**/* | |||
|
|
|||
| Metrics/LineLength: | |||
| Layout/LineLength: | |||
There was a problem hiding this comment.
To fix warning: .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout when running rubocop.
bc-zachary
force-pushed
the
appex-243
branch
from
f6d41fb to
09c236a
Compare
bc-zachary
force-pushed
the
appex-243
branch
from
09c236a to
0a3ebac
Compare
splittingred
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates how response headers are handled to accommodate lowercased header names. New unit test included to verify functionality. Plus an edit in
.rubocop.ymlto get rid of a rubocop error.