feat(payment): PI-3048 [Checkout.com] Remove issuers dropdown and sending BIC #2141
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding BIC to backend
| @@ -37,7 +41,7 @@ const CheckoutcomCustomPaymentMethod: FunctionComponent<PaymentMethodProps> = ({ | |||
|
|
|||
| const billingAddress = checkoutState.data.getBillingAddress(); | |||
|
|
|||
| if (!isCheckoutcomPaymentMethod(checkoutCustomMethod)) { | |||
| if (!isCheckoutcomPaymentMethod(checkoutCustomMethod) || isIdealHostedPageExperimentOn) { | |||
There was a problem hiding this comment.
please add changes to the spec.
vitalii-koshovyi
approved these changes
Jan 14, 2025
animesh1987
approved these changes
Jan 16, 2025
bc-ania
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
iDEAL have updated their central technical infrastructure.
It requires from us to stop calling GET /issuers endpoint on checkout.
The change is under the experiment because according to this comment
we're waiting for official information from Checkoutcom team.
Why?
According to the CheckoutCOM team, the new changes will take effect on April 1, 2025.
We should be informed and then projected rollout of an experiment is 100%.
revert,
disable experiment PI-2979.checkoutcom_enable_ideal_hosted_page
Testing / Proof
Before:
After:
https://github.com/user-attachments/assets/3766b8d8-dc1e-4f72-aa77-e6b8f7ea1caa
@bigcommerce/team-checkout