Skip to content

Commit

Permalink
fix(storefront): STRF-10244 Fix PDP not respecting "quantity box" dis…
Browse files Browse the repository at this point in the history
…play settings
  • Loading branch information
jordanarldt committed Dec 1, 2022
1 parent a3cb0c1 commit 18e2b56
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 26 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Draft
- Set "Show quick payment buttons" setting to true by default [#2283]https://github.com/bigcommerce/cornerstone/pull/2283
- Fixed en-CA translation warning in terminal. [#2278][https://github.com/bigcommerce/cornerstone/pull/2278]
- Fixed PDP not respecting "quantity box" display settings. [#2291](https://github.com/bigcommerce/cornerstone/pull/2291)

## 6.7.0 (11-03-2022)
- Fixed escaping on created store account confirm message. [#2265]https://github.com/bigcommerce/cornerstone/pull/2265
Expand Down
1 change: 0 additions & 1 deletion config.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@
"brandpage_products_per_page": 12,
"searchpage_products_per_page": 12,
"show_product_quick_view": true,
"show_product_quantity_box": true,
"show_powered_by": true,
"shop_by_brand_show_footer": true,
"show_copyright_footer": true,
Expand Down
6 changes: 0 additions & 6 deletions schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1351,12 +1351,6 @@
"force_reload": true,
"id": "show_product_quick_view"
},
{
"type": "checkbox",
"label": "i18n.ShowQuantitySelectionOnProduct",
"force_reload": true,
"id": "show_product_quantity_box"
},
{
"type": "checkbox",
"label": "i18n.ShowProductDescriptionTabs",
Expand Down
18 changes: 0 additions & 18 deletions schemaTranslations.json
Original file line number Diff line number Diff line change
Expand Up @@ -2905,24 +2905,6 @@
"no": "Vis hurtigvisningsknapp på produktkort",
"ko": "상품 카드에 빠른 보기 버튼 표시"
},
"i18n.ShowQuantitySelectionOnProduct": {
"default": "Show quantity selection on product pages",
"fr": "Afficher la sélection de la quantité sur les pages produit",
"it": "Mostra selezione della quantità nelle pagine prodotto",
"uk": "Показати вибір кількості на сторінках товарів",
"zh": "在产品页面显示数量选项框",
"de": "Mengenauswahl auf Produktseiten anzeigen",
"es": "Mostrar la selección de cantidades en las páginas de productos",
"nl": "Hoeveelheidsselectie weergeven op productpaginas",
"pt": "Mostrar seleção de quantidade nas páginas dos produtos",
"sv": "Visa kvantitetsalternativ på produktsidor",
"es-MX": "Mostrar la selección de cantidades en las páginas de productos",
"pt-BR": "Mostrar seleção de quantidade nas páginas dos produtos",
"es-419": "Mostrar selección de cantidad en las páginas de productos",
"da": "Vis mængdevalg på produktsider",
"no": "Vis mengdevalg på produktsidene",
"ko": "상품 상세페이지에 수량 선택 표시"
},
"i18n.ShowProductDescriptionTabs": {
"default": "Show product description tabs",
"fr": "Afficher les onglets de description du produit",
Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/add-to-cart.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div id="add-to-cart-wrapper" class="add-to-cart-wrapper" {{#unless product.can_purchase}}style="display: none"{{/unless}}>
{{#if theme_settings.show_product_quantity_box}}
{{#if product.show_quantity_input}}
{{inject 'productQuantityErrorMessage' (lang 'products.quantity_error_message')}}
<div class="form-field form-field--increments">
<label class="form-label form-label--alternate"
Expand Down

0 comments on commit 18e2b56

Please sign in to comment.