Merge pull request #968 from junedkazi/fix-amp-social

Load amp social share only when we have icons to share.
bigcommerce · Mar 20, 2017 · 2074bc8 · 2074bc8
2 parents 06e9af2 + 4cbdf79
commit 2074bc8
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Draft
 - `stencil.conf.js` was refactored to support webpack2 builds [961](https://github.com/bigcommerce/cornerstone/pull/961)
+- Load amp social share JS only when we have share icons enabled. [#968](https://github.com/bigcommerce/cornerstone/pull/968)
+
 ## 1.6.2 (2017-03-15)
 - Fix a bug that was not updating price and weight when an option is selected [#963](https://github.com/bigcommerce/cornerstone/pull/963)
 

diff --git a/templates/components/amp/products/product-view.html b/templates/components/amp/products/product-view.html
@@ -65,11 +65,13 @@ <h4 class="productAccordion-title">Description</h4>
         {{#if settings.show_product_reviews}}
             {{> components/amp/products/reviews reviews=product.reviews product=product urls=urls}}
         {{/if}}
-        <section expanded class="productAccordion">
-            <h4 class="productAccordion-title">Share</h4>
-            <div class="productAccordion-content social-share">
-                {{> components/amp/common/share }}
-            </div>
-        </section>
+        {{#if settings.add_this.buttons}}
+            <section expanded class="productAccordion">
+                <h4 class="productAccordion-title">Share</h4>
+                <div class="productAccordion-content social-share">
+                    {{> components/amp/common/share }}
+                </div>
+            </section>
+        {{/if}}
     </amp-accordion>
 </div>
diff --git a/templates/pages/amp/product.html b/templates/pages/amp/product.html
@@ -13,9 +13,11 @@
 {{#partial "amp-scripts"}}
     <script async custom-element="amp-accordion" src="https://cdn.ampproject.org/v0/amp-accordion-0.1.js"></script>
     <script async custom-element="amp-carousel" src="https://cdn.ampproject.org/v0/amp-carousel-0.1.js"></script>
-    <script async custom-element="amp-social-share" src="https://cdn.ampproject.org/v0/amp-social-share-0.1.js"></script>
+    {{#if settings.add_this.buttons}}
+        <script async custom-element="amp-social-share" src="https://cdn.ampproject.org/v0/amp-social-share-0.1.js"></script>
+    {{/if}}
     {{#if product.options}}
-    <script async custom-element="amp-iframe" src="https://cdn.ampproject.org/v0/amp-iframe-0.1.js"></script>
+        <script async custom-element="amp-iframe" src="https://cdn.ampproject.org/v0/amp-iframe-0.1.js"></script>
     {{/if}}
     {{#if product.videos}}
         <script async custom-element="amp-youtube" src="https://cdn.ampproject.org/v0/amp-youtube-0.1.js"></script>