Skip to content

Commit

Permalink
Fix social sharing links for product pages and blog posts (#2082)
Browse files Browse the repository at this point in the history
  • Loading branch information
rowleyaj authored Jul 22, 2021
1 parent 0a7f7db commit 2878672
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Fix social share links for product pages and blog posts [#2082](https://github.com/bigcommerce/cornerstone/pull/2082)
- 'undefined' is announced with screen reader while changing Product quantity on PDP. [#2094](https://github.com/bigcommerce/cornerstone/pull/2094)
- Counter on the Wish Lists tab on Account page has been removed. [#2087](https://github.com/bigcommerce/cornerstone/pull/2087)
- User Account, bug styles in section payment methods. [#2085](https://github.com/bigcommerce/cornerstone/pull/2085)
Expand Down
2 changes: 1 addition & 1 deletion templates/components/blog/post.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ <h2 class="blog-title">
{{/if}}
{{/if}}

{{>components/common/share}}
{{>components/common/share url=post.url}}

</div>
</article>
2 changes: 1 addition & 1 deletion templates/components/common/share.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#if settings.add_this.buttons}}
{{assignVar 'encodedUrl' (encodeURI this.post.url)}}
{{assignVar 'encodedUrl' (encodeURI url)}}
{{assignVar 'encodedTitle' (encodeURI head.title)}}
<div>
<ul class="socialLinks">
Expand Down

0 comments on commit 2878672

Please sign in to comment.