Skip to content

Commit

Permalink
fix(storefront): BCTHEME-288 Shoppers are not anchor-linked to review…
Browse files Browse the repository at this point in the history
…s on PDPs if product description tabs are enabled
  • Loading branch information
BC-tymurbiedukhin committed Oct 22, 2020
1 parent 1e897b4 commit 555819d
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled. [#1883](https://github.com/bigcommerce/cornerstone/pull/1883)
- Fixed Product Image Carousel Becomes Responsiveness on Product Page. [#1879](https://github.com/bigcommerce/cornerstone/pull/1879)
- Move phrases and static strings to en.json for improving translation customizing. [#1850](https://github.com/bigcommerce/cornerstone/pull/1850)
- Update carousel images to improve LCP indicator from Lighthouse performance report. [#1876](https://github.com/bigcommerce/cornerstone/pull/1876)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/product/reviews.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default class {
initLinkBind() {
const $content = $('#productReviews-content', this.$reviewsContent);

$('.productView-reviewLink').on('click', () => {
$('#productReview_link').on('click', () => {
$('.productView-reviewTabLink').trigger('click');
if (!$content.hasClass('is-open')) {
this.$collapsible.trigger(CollapsibleEvents.click);
Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/product-view.html
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ <h2 class="productView-brand"{{#if schema}} itemprop="brand" itemscope itemtype=
{{> components/products/ratings rating=product.rating}}
</span>
{{#if product.num_reviews '>' 0}}
<a href="{{product.url}}#product-reviews" class=" ">
<a href="{{product.url}}#product-reviews" id="productReview_link">
{{lang 'products.reviews.link_to_review' total=product.num_reviews}}
</a>
{{else}}
Expand Down

0 comments on commit 555819d

Please sign in to comment.