Merge pull request #2005 from kwang30/ES-2031

ES-2031 display error message when star search fails with prod filtering enabled
bigcommerce · Mar 11, 2021 · 5710ac6 · 5710ac6
2 parents 9119b6d + 161d8d7
commit 5710ac6
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Added unique identifiers to product cards on product list pages. [#1999](https://github.com/bigcommerce/cornerstone/pull/1999)
 - Fixed line breaks on Dropdown menu display mode. [#1996](https://github.com/bigcommerce/cornerstone/pull/1996)
 - Added notifications on Carousel's content cahnge through 'Next/Prev' buttons. [#1986](https://github.com/bigcommerce/cornerstone/pull/1986)
+- Add error message when faceted search fails on search, category, brand pages [#2005](https://github.com/bigcommerce/cornerstone/pull/2005)
 
 ## 5.2.0 (02-22-2021)
 - Fixed cut off on Cart button when Zooming up to 400%. [#1988](https://github.com/bigcommerce/cornerstone/pull/1988)

diff --git a/lang/en.json b/lang/en.json
@@ -826,7 +826,7 @@
         "state_error": "There was a problem retrieving states/provinces"
     },
     "search": {
-        "errorMessage": "There was a problem retrieving your search results. Please try again in a few seconds, or try a different search.",
+        "errorMessage": "There was a problem retrieving your results. Please try again in a few seconds.",
         "quick_search": {
             "input_label": "Search",
             "input_placeholder": "Search the store"

diff --git a/templates/components/category/product-listing.html b/templates/components/category/product-listing.html
@@ -19,11 +19,15 @@
 
     {{> components/common/paginator pagination.category}}
 {{else}}
-    <p data-no-products-notification
-       role="alert"
-       aria-live="assertive"
-       tabindex="-1"
-    >
-        {{lang 'categories.no_products'}}
-    </p>
+    {{#if category.search_error}}
+        <p>{{lang 'search.errorMessage'}}</p>
+    {{else}}
+        <p data-no-products-notification
+           role="alert"
+           aria-live="assertive"
+           tabindex="-1"
+        >
+            {{lang 'categories.no_products'}}
+        </p>
+    {{/if}}
 {{/if}}
diff --git a/templates/pages/brand.html b/templates/pages/brand.html
@@ -32,12 +32,16 @@ <h1 class="page-heading">{{brand.name}}</h1>
     </aside>
 
     <main class="page-content" id="product-listing-container">
-        {{#if brand.products}}
-            {{> components/brand/product-listing}}
+        {{#if brand.search_error }}
+            <p>{{lang 'search.errorMessage'}}</p>
         {{else}}
-            <p>{{lang 'brands.no_products'}}</p>
+            {{#if brand.products}}
+                {{> components/brand/product-listing}}
+            {{else}}
+                <p>{{lang 'brands.no_products'}}</p>
+            {{/if}}
+            {{{region name="brand_below_content"}}}
         {{/if}}
-        {{{region name="brand_below_content"}}}
     </main>
 </div>