STRF-4496 - Fix product options unhiding indexing issue (#1176)

bigcommerce · Mar 5, 2018 · 746f539 · 746f539
1 parent 421a542
commit 746f539
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- Fix product options unhiding indexing issue. [#1176](https://github.com/bigcommerce/cornerstone/pull/1176)
 
 ## 1.13.2 (2018-02-28)
 

diff --git a/assets/js/theme/common/select-option-plugin.js b/assets/js/theme/common/select-option-plugin.js
@@ -41,10 +41,12 @@ function toggleOption(show) {
     // move the option to the correct select element if required
     if (currentSelectElement.is(':disabled') && show) {
         const previousIndex = this.data('index');
-        if (previousIndex > 0) {
-            this.insertAfter(selectElement.find(`option:eq(${previousIndex - 1})`));
+        const $elementNowAtPreviousIndex = selectElement.find(`option:eq(${previousIndex})`);
+
+        if ($elementNowAtPreviousIndex.length) {
+            this.insertBefore($elementNowAtPreviousIndex);
         } else {
-            $(this).prependTo(selectElement);
+            $(this).appendTo(selectElement);
         }
     } else if (!currentSelectElement.is(':disabled') && !show) {
         this.data('index', currentSelectElement.find('option').index(this));