Use distinct names for artifacts

bigcommerce · Oct 19, 2024 · 7bf4367 · 7bf4367
1 parent 2698035
commit 7bf4367
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/.github/workflows/pull_request_review.yml b/.github/workflows/pull_request_review.yml
@@ -13,12 +13,13 @@ on:
 jobs:
   build:
 
-    runs-on: ubuntu-latest
-
     strategy:
       matrix:
+        os: [ubuntu-latest, windows-latest]
         node: [18.x, 20.x]
 
+    runs-on: ${{ matrix.os }}
+
     steps:
     - name: Checkout code
       uses: actions/checkout@v2
@@ -32,9 +33,9 @@ jobs:
       uses: actions/cache@v2
       with:
         path: ~/.npm
-        key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+        key: ${{ matrix.os }}-node-${{ hashFiles('**/package-lock.json') }}
         restore-keys: |
-          ${{ runner.os }}-node-
+          ${{ matrix.os }}-node-${{ matrix.node }}
 
     - name: Install Stencil CLI Dependency
       run: npm install -g @bigcommerce/stencil-cli
@@ -46,17 +47,19 @@ jobs:
       run: npx grunt check
 
     - name: Validate theme successfully bundles
-      run: npx stencil bundle --name bundle
+      run: npx stencil bundle --name ${{ matrix.os }}-node-${{ matrix.node }}-bundle
 
     - name: Upload bundled theme
       uses: actions/upload-artifact@v4
       with:
-        name: Bundled Theme
-        path: bundle.zip
+        name: Bundled-Theme-${{ matrix.os }}-node-${{ matrix.node }}
+        path: ${{ matrix.os }}-node-${{ matrix.node }}-bundle.zip
+
+    - name: Rename bundle analysis report
+      run: mv assets/dist/report.html assets/dist/${{ matrix.os }}-node-${{ matrix.node }}-report.html
 
     - name: Upload bundle analysis
       uses: actions/upload-artifact@v4
       with:
-        name: Webpack Analysis
-        path: assets/dist/report.html
-
+        name: Webpack-Analysis-${{ matrix.os }}-node-${{ matrix.node }}
+        path: assets/dist/${{ matrix.os }}-node-${{ matrix.node }}-report.html