Skip to content

Commit

Permalink
fix(storefront): BCTHEME-507 Translation Gap: Account -> Wish List ->…
Browse files Browse the repository at this point in the history
… Name required message. (#2060)
  • Loading branch information
bc-yevhenii-buliuk authored Jun 3, 2021
1 parent 3b16d3c commit debe25e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Translation Gap: Account -> Wish List -> Name required message. [#2060](https://github.com/bigcommerce/cornerstone/pull/2060)
- Translation Gap: Cart -> Shipping estimator error messages. [#2066](https://github.com/bigcommerce/cornerstone/pull/2066)
- Add to cart button and Wishlist should be on one line on desktop. [#2050](https://github.com/bigcommerce/cornerstone/pull/2050)
- Logo on AMP Product details page (PDP) doesn't fit header. [#2054](https://github.com/bigcommerce/cornerstone/pull/2054)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/wishlist.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default class WishList extends PageManager {

cb(result);
},
errorMessage: 'You must enter a wishlist name.',
errorMessage: this.context.enterWishlistNameError,
},
]);

Expand Down
3 changes: 2 additions & 1 deletion lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,8 @@
"save": "Save Wish List",
"delete_alert": "Are you sure you want to delete your Wish List(s)? This action cannot be undone.",
"create_new": "Create New Wish List",
"add_to_default": "Add to My Wish List"
"add_to_default": "Add to My Wish List",
"enter_wishlist_name_error": "You must enter a wishlist name."
}
},
"page": {
Expand Down
2 changes: 2 additions & 0 deletions templates/components/account/add-wishlist.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{{inject 'enterWishlistNameError' (lang 'account.wishlists.enter_wishlist_name_error')}}

<div class="wishlist-add">
<header class="wishlist-header">
{{#if forms.wishlist.id}}
Expand Down

0 comments on commit debe25e

Please sign in to comment.