feature(storefront): BCTHEME-142 Unnecessary heading on product cards

bigcommerce · Aug 6, 2020 · f928f73 · f928f73
1 parent 54ddcef
commit f928f73
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/templates/components/amp/products/card.html b/templates/components/amp/products/card.html
@@ -22,9 +22,9 @@
         {{#if brand.name}}
             <p class="card-text" data-test-info-type="brandName">{{brand.name}}</p>
         {{/if}}
-        <h4 class="card-title">
+        <span class="card-title">
             <a data-vars-product-link="{{url}}" data-vars-product-id="{{id}}" data-vars-product-name="{{name}}" href="{{url}}">{{name}}</a>
-        </h4>
+        </span>
 
         <div class="card-text" data-test-info-type="price">
             {{#or customer (if theme_settings.restrict_to_login '!==' true)}}

diff --git a/templates/components/products/card.html b/templates/components/products/card.html
@@ -74,9 +74,9 @@
         {{#if brand.name}}
             <p class="card-text" data-test-info-type="brandName">{{brand.name}}</p>
         {{/if}}
-        <h4 class="card-title">
+        <span class="card-title">
             <a href="{{url}}" {{#if settings.data_tag_enabled}} data-event-type="product-click" {{/if}}>{{name}}</a>
-        </h4>
+        </span>
 
         <div class="card-text" data-test-info-type="price">
             {{#or customer (if theme_settings.restrict_to_login '!==' true)}}

diff --git a/templates/pages/brands.html b/templates/pages/brands.html
@@ -27,9 +27,9 @@ <h1 class="page-heading">{{lang 'brand.label'}}</h1>
                         </a>
                     </figure>
                     <div class="card-body">
-                        <h4 class="card-title">
+                        <span class="card-title">
                             <a href="{{url}}">{{name}}</a>
-                        </h4>
+                        </span>
                     </div>
                 </article>
             </li>

diff --git a/templates/pages/compare.html b/templates/pages/compare.html
@@ -32,9 +32,9 @@ <h1 class="page-heading">{{lang 'compare.header' products=comparisons.length}}</
                             {{#if brand.name}}
                                 <p class="card-text"><a href="{{brand.url}}">{{ brand.name }}</a></p>
                             {{/if}}
-                            <h4 class="card-title">
+                            <span class="card-title">
                                 <a href="{{url}}">{{ name }}</a>
-                            </h4>
+                            </span>
                             {{#or ../customer (if ../theme_settings.restrict_to_login '!==' true)}}
                                 {{#if price_range}}
                                     {{> components/products/price-range}}