Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter / X Logo for Social Sharing and Social Links #2386

Closed
AndrewBarber opened this issue Aug 12, 2023 · 2 comments
Closed

Twitter / X Logo for Social Sharing and Social Links #2386

AndrewBarber opened this issue Aug 12, 2023 · 2 comments

Comments

@AndrewBarber
Copy link
Contributor

Expected behavior

Social Share and Social Link icons should display the new X logo instead of the twitter logo.

Actual behavior

The twitter logo is displayed.

Steps to reproduce behavior

Social Icons - Enable Social Icons in the theme in the header or footer, add a link within the BC Admin panel, and run the theme.
Social Share - Enable Social Sharing from PDP, run the theme.
@AndrewBarber
Copy link
Contributor Author

PR Incoming...

AndrewBarber added a commit to AndrewBarber/cornerstone that referenced this issue Aug 12, 2023
@AndrewBarber
Update Twitter / X Logo for Social Sharing and Social Links bigcommer…
fade6ee 
…ce#2386
AndrewBarber added a commit to AndrewBarber/cornerstone that referenced this issue Aug 12, 2023
@AndrewBarber
Update changelog bigcommerce#2386
e22a8ce
@AndrewBarber AndrewBarber mentioned this issue Aug 12, 2023
Merged
1 task
AndrewBarber added a commit to AndrewBarber/cornerstone that referenced this issue Aug 14, 2023
@AndrewBarber
Add links to changelog bigcommerce#2386
d2d8464
AndrewBarber added a commit to AndrewBarber/cornerstone that referenced this issue Aug 14, 2023
@AndrewBarber
Add static display_name to remove mention of Twttr bigcommerce#2386
56a3363
BC-krasnoshapka pushed a commit that referenced this issue Aug 16, 2023
@AndrewBarber
2386 replace twitter image (#2387)
13749be 
* Update Twitter / X Logo for Social Sharing and Social Links #2386

* Update changelog #2386

* Add links to changelog #2386

* Add static display_name to remove mention of Twttr  #2386
@AndrewBarber
Copy link
Contributor Author

Closing issue as this has now been merged. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewBarber