Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): STRF-4866 Fix missing quantity/selection for AMP product Page #1242

Merged
merged 1 commit into from
May 29, 2018
Merged

fix(storefront): STRF-4866 Fix missing quantity/selection for AMP product Page #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Fix product pricing schema.org microdata. [#1233](https://github.com/bigcommerce/cornerstone/pull/1233)
- Removed unused browserlist. [#1241](https://github.com/bigcommerce/cornerstone/pull/1241)
- Fix for ESLint "no-console" warning. [#1237](https://github.com/bigcommerce/cornerstone/pull/1237)
- Fix quantity edit on Simple Product AMP pages. [#1242](https://github.com/bigcommerce/cornerstone/pull/1242)

## 1.18.0 (2018-05-09)
- Add the +/- icons for the category filtering [#1211](https://github.com/bigcommerce/cornerstone/pull/1211)
Expand Down
18 changes: 7 additions & 11 deletions templates/components/amp/products/product-view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,13 @@
</section>
<div class="productView-action">
{{#or customer (if theme_settings.restrict_to_login '!==' true)}}
{{#if product.options}}
<amp-iframe height="400" width="250"
layout="responsive"
sandbox="allow-forms allow-pointer-lock allow-popups allow-same-origin allow-scripts allow-top-navigation allow-modals"
resizable
src="{{product.amp_options_url}}">
<div class="button button--primary button--wide" overflow tabindex="0" role="button">Choose Options</div>
</amp-iframe>
{{else}}
<a class="button button--primary button--wide" role="button" href="{{product.cart_url}}">Add To Cart</a>
{{/if}}
<amp-iframe height="400" width="250"
layout="responsive"
sandbox="allow-forms allow-pointer-lock allow-popups allow-same-origin allow-scripts allow-top-navigation allow-modals"
resizable
src="{{product.amp_options_url}}">
<div class="button button--primary button--wide" overflow tabindex="0" role="button">Choose Options</div>
</amp-iframe>
{{/or}}
{{#if product.out_of_stock}}
{{#if product.out_of_stock_message}}
Expand Down
4 changes: 1 addition & 3 deletions templates/pages/amp/product.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
{{#if settings.add_this.buttons}}
<script async custom-element="amp-social-share" src="https://cdn.ampproject.org/v0/amp-social-share-0.1.js"></script>
{{/if}}
{{#if product.options}}
<script async custom-element="amp-iframe" src="https://cdn.ampproject.org/v0/amp-iframe-0.1.js"></script>
{{/if}}
<script async custom-element="amp-iframe" src="https://cdn.ampproject.org/v0/amp-iframe-0.1.js"></script>
{{#if product.videos}}
<script async custom-element="amp-youtube" src="https://cdn.ampproject.org/v0/amp-youtube-0.1.js"></script>
{{/if}}
Expand Down