Changed Slick Carousel lazyLoad technique to Anticipated. #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cornerstone has an issue where the first image in a carousel appears to reload on wrap. This "reload" happens despite the browser not making any new GETs.
This behavior is fixed by changing the Slick Carousel's lazy load technique back from
ondemandtoanticipated.Slick Carousel's documentation has, at time of this PR, removed mentions of
anticipatedas a lazyLoad technique: https://github.com/kenwheeler/slick/blob/a2aa3fec335c50aceb58f6ef6d22df8e5f3238e1/README.markdown. The only two documented options areondemandandprogressive.progressiveis markedly worse thanondemandin terms of performance. However,anticipatedis still used to determine logic inslick.js, in both 1.8.1 and 1.9.0:1.8.1: https://github.com/kenwheeler/slick/blob/ee7d37faeb92c4619ffeefeba2cc4c733f39b1b3/slick/slick.js
1.9.0: https://github.com/kenwheeler/slick/blob/a2aa3fec335c50aceb58f6ef6d22df8e5f3238e1/slick/slick.js
This PR comes after digging into Slick Carousel with #1259.
Tickets / Documentation
Screenshots and Reports
Reports were done on a test store. These stores are light, with very few products and zero customizations. The margin in performance should be significantly wider on a live store.
These reports were generated by Lighthouse and can be viewed in a human-readable form at https://googlechrome.github.io/lighthouse/viewer2x/.
Before: ondemand
ondemand.txt
After: anticipated
anticipated.txt