-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MERC-3746 cornerstone schema change #1350
Conversation
}, | ||
{ | ||
"type": "paragraph", | ||
"content": "* the 'Product price label' is displayed when there is not a sale price." | ||
"content": "* the 'Product price label' is displayed when there is not a sale price.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't we need force reload for type paragraph
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is just a
element, and shouldn't need a force reload as we are not making any changes. @pedelman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kchu93 awesome work on this one 👏 . Can you add a changelog entry as well for the PR.
@Ubersmake can we do some smoke test on this one. Just randomly test some of the changes part of this PR and make sure everything is working as expected.
d60cbc8
to
9231e0c
Compare
💚 I've tested one of the sections changed in I also tried uploading a version without the changes in this PR, saving a configuration, and then upgrading that theme to one with the changes in |
04da948
to
ccbbde7
Compare
ccbbde7
to
4bbff3b
Compare
What?
Cornerstone - Update Schema labels and organization;
Updated the labels and organization of cornerstone of schema.json entries.
Why?
In preparation for launching Store Design, the merchandising team performed an audit on the cornerstone settings that are available finding a large number of usability gaps. As a short-term solution, the team made the following changes focusing on providing a better legibility of the setting.
Tickets / Documentation
Add links to any relevant tickets and documentation.