-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STRF-3591 add return instructions in return-saved.html #1525
STRF-3591 add return instructions in return-saved.html #1525
Conversation
Autotagging @bigcommerce/storefront-team @davidchin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just need to make sure language is in a language file and add a changelog.
Thanks!
c8442a8
to
ca28fc0
Compare
d9de54c
to
54b32e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase - otherwise this is good to go.
2cb8a03
to
60fc8ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but needs rebase
60fc8ad
to
2cb1cb9
Compare
2cb1cb9
to
4779017
Compare
rebased. |
What?
Previously return instructions did not appear after submitting a return request and one would need to edit the template file in return-saved.html to display return instructions even if they had configured returns instructions in the control panel. This pull request is to fix that issue.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Attach images or add image links here.