Fix tall images on PDPs and PLPs #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
mattolson
previously approved these changes
Aug 13, 2019
|
Looks like this doesn't work on IE11. Need to look for a better solution. |
bookernath
force-pushed
the
fix-tall-images
branch
from
92c3038 to
3fd8aef
Compare
|
@mattolson ♻️ |
bookernath
force-pushed
the
fix-tall-images
branch
from
3fd8aef to
dad4fde
Compare
|
I've added this polyfill for IE11: https://github.com/fregante/object-fit-images We can remove it when we no longer need to support IE11 |
mattolson
reviewed
Aug 14, 2019
|
It's 3kb before gzip: https://github.com/fregante/object-fit-images/blob/master/dist/ofi.min.js |
|
@mattolson I've added a conditional to make it only execute for IE11. Let me know if you think we should further optimize. |
junedkazi
reviewed
Aug 14, 2019
mattolson
suggested changes
Aug 14, 2019
bookernath
force-pushed
the
fix-tall-images
branch
from
6758ca7 to
dad4fde
Compare
mattolson
approved these changes
Aug 14, 2019
bookernath
added a commit
that referenced
this pull request
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cornerstone 4.0 introduced a bug in which images which are particularly tall (portrait) are stretched on PDPs and PLPs:
This fixes that using
object-fit: contain.Tickets / Documentation
Screenshots (if appropriate)