fix(search): ES-1322 fixed the collapse and expand issue for custom filter without no special characters #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilter without no special chanracters
|
Autotagging @bigcommerce/storefront-team @davidchin |
lord2800
approved these changes
Jun 15, 2020
kvnwang
approved these changes
Jun 16, 2020
junedkazi
approved these changes
Jun 16, 2020
|
Tested with attached to the ticket theme. Looks good 💚 |
|
Doesn't work if the filter name contains special characters %+&:()? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Custom filter without '&' is not collapsable
Since custom filter without
&and if it hasempty spacebetween the words (Ex: Custom Size), thedata-collapsibleelement is broken in the html source. With this fix,Tickets / Documentation
Screenshots (if appropriate)
All the filters are collapsed
Standard filters are expanded
Both custom filters are expanded
One custom collapsed (custom filter without
&in it) and other one is expanded (custom filter with&in it)One custom collapsed (custom filter with
&in it) and other one is expanded (custom filter without&in it)