Move clear link outside of Faceted Search navigation button #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Componentize navigation - Remove some extraneous whitespace - Remove unneeded “../“ - Remove unneeded Replace helper - Move “Remove” link outside button
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
@bigcommerce/artemis-dt |
lord2800
approved these changes
Jul 30, 2020
junedkazi
reviewed
Jul 30, 2020
| @@ -46,7 +27,7 @@ <h5 class="accordion-title"> | |||
| </ul> | |||
|
|
|||
| {{#if show_more_toggle}} | |||
| <a href="#facetedSearch-navList--{{#replace '&' (hyphenate facet) }}{{else}}{{hyphenate facet}}{{/replace}}" role="button" class="toggleLink"> | |||
| <a href="#facetedSearch-navList--{{dashcase facet}}" role="button" class="toggleLink"> | |||
There was a problem hiding this comment.
@lord2800 will this break things for facets which have & ?
There was a problem hiding this comment.
@junedkazi , Nope! IMO, dashcase is the correct helper to use here as it strips special characters and converts everything into a nice, usable form.
There was a problem hiding this comment.
Yeah, I wish I'd found that when we were initially looking into that problem. 😢
junedkazi
approved these changes
Aug 5, 2020
|
@mattcoy-arcticleaf this is good to go. We need to hold off on merge because we are in the process of doing a release. As soon as that is rolled out we will merge this one. |
|
@junedkazi no worries. Do you want me to make a changelog entry? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The current HTML markup for the link to clear faceted search element's items is invalid as it is located inside a button. This update moves the clear link outside the navigation button, so it no longer violates W3C markup standards (see below for a screenshot of the error message). This update also adds padding so the title of the filter does not overlap with the clear button.
Additionally, this update componentizes the faceted search navigation. Previously, the faceted search navigation code was repeated in the exact same code across 3 different templates.
Lastly, this update cleans up some extraneous whitespace (for consistency with the rest of the codebase) and otherwise questionable code.
The only visible change to the theme is, as stated above, the padding adjustment to prevent the overlap of the faceted search filter title and the clear button.
Tickets / Documentation
N/A
Screenshots (if appropriate)