feature(storefront): BCTHEME-134 Incorrect focus order on PDPs #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
BC-tymurbiedukhin
approved these changes
Aug 6, 2020
yurytut1993
force-pushed
the
BCTHEME-134
branch
from
8b73dc0 to
78bc9c9
Compare
bc-alexsaiannyi
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Now when you tabbing through page product images fill receive focus firstly before focusable items in product details block (for example write review link).
To do this I moved block with images above details block in html. Because of using floats in css, changing block position didn't affect visual presentation of layout. But on mobile I should have details block higher than images block. So I have to use flex and change the order of details block to set him at the top using order: -1. Tabbing on mobile is not necessary, so order on mob devices might be not important.
Alternative variant - have 2 similar details html blocks - one above images block and one under. On mobile version will be active above block, and on desktop under block
Tickets / Documentation
Ticket
Screenshots (if appropriate)
layout with wrong order
correct order demo
correct_focus_order.zip