Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-143 Improper heading hierarchy on PLPs #1779

Merged
merged 2 commits into from
Aug 26, 2020
Merged

fix(storefront): BCTHEME-143 Improper heading hierarchy on PLPs #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a46c18
fix(storefront): BCTHEME-143 Improper heading hierarchy on PLPs
BC-tymurbiedukhin Aug 12, 2020
c3af20e
Merge branch 'master' into BCTHEME-143
BC-tymurbiedukhin Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed improper heading hierarchy on PLPs. [#1779](https://github.com/bigcommerce/cornerstone/pull/1779)
- Cornerstone - Cart link not visible on mobile Chrome depending on swatch image size. [#1793](https://github.com/bigcommerce/cornerstone/pull/1793)
- Added a valid ARIA role for li elemenents on "Related Products" tab [#1782](https://github.com/bigcommerce/cornerstone/pull/1782)
- Fixed IDs used in ARIA and labels which are not unique. [#1791](https://github.com/bigcommerce/cornerstone/pull/1791)
Expand Down
1 change: 1 addition & 0 deletions assets/scss/components/foundation/accordion/_accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
}

.accordion-title {
font-size: remCalc(15px);
margin: 0;
}

Expand Down
1 change: 1 addition & 0 deletions assets/scss/layouts/sidebar/_block.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
}

.sidebarBlock-heading {
font-size: remCalc(15px);
margin-top: 0;
text-transform: inherit;
}
2 changes: 1 addition & 1 deletion templates/components/category/shop-by-price.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{#and theme_settings.shop_by_price_visibility shop_by_price}}
<div class="sidebarBlock">
<h5 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h5>
<h2 class="sidebarBlock-heading">{{lang 'category.shop_by_price'}}</h2>
<ul class="navList">
{{#each shop_by_price}}
<li class="navList-item">
Expand Down
2 changes: 1 addition & 1 deletion templates/components/category/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<nav>
{{#if category.subcategories}}
<div class="sidebarBlock">
<h5 class="sidebarBlock-heading">{{category.name}}</h5>
<h2 class="sidebarBlock-heading">{{category.name}}</h2>
<ul class="navList">
{{#each category.subcategories}}
<li class="navList-item">
Expand Down
4 changes: 2 additions & 2 deletions templates/components/faceted-search/selected-facets.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="facetedSearch-refineFilters sidebarBlock">
<h5 class="sidebarBlock-heading">
<h2 class="sidebarBlock-heading">
{{lang 'search.faceted.selected.title'}}
</h5>
</h2>

{{#if items}}
<ul class="inlineList inlineList--labels">
Expand Down