Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-144 Button inputs with the same name attribu… #1792

Merged
merged 2 commits into from
Aug 26, 2020
Merged

fix(storefront): BCTHEME-144 Button inputs with the same name attribu… #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77f0f2c
fix(storefront): BCTHEME-144 Button inputs with the same name attribu…
BC-tymurbiedukhin Aug 25, 2020
86eb2f3
Merge branch 'master' into BCTHEME-144
BC-tymurbiedukhin Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Button inputs with the same name attribute should be part of a group. [#1792](https://github.com/bigcommerce/cornerstone/pull/1792)
- Fixed Shop by price insufficient link text. [#1786](https://github.com/bigcommerce/cornerstone/pull/1786)
- Fixed improper heading hierarchy on Add to Cart modal recommendation. [#1784](https://github.com/bigcommerce/cornerstone/pull/1784)
- Fixed improper heading hierarchy on Add to Cart modal heading. [#1783](https://github.com/bigcommerce/cornerstone/pull/1783)
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/options/product-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="form-field" data-product-attribute="product-list">
<label class="form-label form-label--alternate form-label--inlineSmall">
<div class="form-field" data-product-attribute="product-list" role="radiogroup" aria-labelledby="product-list-label">
<label class="form-label form-label--alternate form-label--inlineSmall" id="product-list-label">
{{display_name}}:
<span data-option-value></span>

Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/options/set-radio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="form-field" data-product-attribute="set-radio">
<label class="form-label form-label--alternate form-label--inlineSmall">
<div class="form-field" data-product-attribute="set-radio" role="radiogroup" aria-labelledby="radio-group-label">
<label class="form-label form-label--alternate form-label--inlineSmall" id="radio-group-label">
{{ this.display_name }}:

{{> components/common/requireness-msg}}
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/options/set-rectangle.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="form-field" data-product-attribute="set-rectangle">
<label class="form-label form-label--alternate form-label--inlineSmall">
<div class="form-field" data-product-attribute="set-rectangle" role="radiogroup" aria-labelledby="rectangle-group-label">
<label class="form-label form-label--alternate form-label--inlineSmall" id="rectangle-group-label">
{{this.display_name}}:
<span data-option-value></span>

Expand Down