-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storefront): STRF-8607 Unified browsers list that we support #1836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved, but EOLs needed in .browserslistrc and babel.config.js
.browserslistrc
Outdated
@@ -0,0 +1 @@ | |||
last 1 version, >2% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we are dropping firefox ESR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken the list of supported browsers from the documentation: https://support.bigcommerce.com/s/article/Themes-Supported-Browsers. Firefox ESR stands for firefox 52
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this to >2%
is a big change. We should check with @bookernath @bc-as before we make this change. Also we should stick with the last 2 versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last 2 versions > will mean, that we will include IE 10 support and polyfills for it. The doc https://support.bigcommerce.com/s/article/Themes-Supported-Browsers also says, that we are targeting more then 2% browsers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed and I just want a confirmation from product that the doc is right or if it needs updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets go with: >2%, last 1 version, Firefox ESR
What?
Cornerstone had webpack config that overrides babel for the browsers list support. That list was updated to target the browsers, that are in the documentation
Tickets / Documentation
https://support.bigcommerce.com/s/article/Themes-Supported-Browsers
Screenshots (if appropriate)