Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-190 Content should not scroll in two directions when zoomed #1853

Merged
merged 2 commits into from
Oct 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# Changelog

## Draft
- Content should not scroll in two directions when zoomed. [#1853](https://github.com/bigcommerce/cornerstone/pull/1853)
- Notification of number of products not announced. [#1845](https://github.com/bigcommerce/cornerstone/pull/1845)
- Quick search query param needs to be fixed while navigating to search page. [#230](https://jira.bigcommerce.com/browse/BCTHEME-230)
- Quick search query param needs to be fixed while navigating to search page. [#230](https://jira.bigcommerce.com/browse/BCTHEME-230)
- Quick search query param needs to be fixed while navigating to search page. [#1832](https://github.com/bigcommerce/cornerstone/pull/1832)
- Zooming and scaling must not be disabled. [#1843](https://github.com/bigcommerce/cornerstone/pull/1843)
- Options on change modal need focus border. [#1839](https://github.com/bigcommerce/cornerstone/pull/1839)
- Product cards should link to products. [#1842](https://github.com/bigcommerce/cornerstone/pull/1842)
Expand Down
9 changes: 8 additions & 1 deletion assets/scss/components/stencil/productView/_productView.scss
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,17 @@

// Details
// -----------------------------------------------------------------------------
//
// 1. for Androind Chrome and IE with zoom horizontal scroll fix
//
// -----------------------------------------------------------------------------

.productView-details {
padding-bottom: spacing("single") + spacing("third");
overflow: hidden; // for Androind Chrome horizontal scroll fix

&.product-options {
overflow: hidden; // 1
}
}


Expand Down
2 changes: 1 addition & 1 deletion templates/components/products/product-view.html
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ <h2 class="productView-brand"{{#if schema}} itemprop="brand" itemscope itemtype=
</div>
</section>

<section class="productView-details">
<section class="productView-details product-options">
<div class="productView-options">
{{#if product.release_date }}
<p>{{product.release_date}}</p>
Expand Down