Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-86 Cornerstone - Text hover color does not change when Dropdown menu display mode is set to Alternative #1918

Merged
merged 2 commits into from
Dec 1, 2020
Merged

fix(storefront): BCTHEME-86 Cornerstone - Text hover color does not change when Dropdown menu display mode is set to Alternative #1918

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc0e3d9
fix(storefront): BCTHEME-86 Cornerstone - Text hover color does not c…
yurytut1993 Nov 30, 2020
167253c
Merge branch 'master' into BCTHEME-86
BC-tymurbiedukhin Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Cornerstone - Text hover color does not change when Dropdown menu display mode is set to 'Alternative'. [#1918](https://github.com/bigcommerce/cornerstone/pull/1918)
- Selecting product options doesn't update image on PDP in Internet Explorer. [#1913](https://github.com/bigcommerce/cornerstone/pull/1913)
- HTML Entity displayed as is via system/error message on a Storefront. [#1888](https://github.com/bigcommerce/cornerstone/pull/1888)
- Shoppers are not anchor-linked to reviews on PDPs if product description tabs are enabled. [#1883](https://github.com/bigcommerce/cornerstone/pull/1883)
Expand Down
31 changes: 13 additions & 18 deletions assets/scss/components/stencil/navPages/_navPages.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,28 +202,31 @@
}
}

&.is-open,
.collapsible-icon-wrapper.is-open {
// scss-lint:disable NestingDepth
svg {
fill: $navPage-subMenu-item--is-highlighted-color;
stroke: $navPage-subMenu-item--is-highlighted-color;
}
}

@include breakpoint("medium") {
display: inline-block;
padding: spacing("half") (spacing("half") + spacing("quarter")) (spacing("half") + spacing("quarter"));

&.is-open {
background-color: stencilColor("navPages-subMenu-backgroundColor");

// scss-lint:disable NestingDepth
svg {
fill: stencilColor("navPages-color-hover");
stroke: stencilColor("navPages-color-hover");
}
background-color: $navPage-subMenu-item--is-highlighted-background;
}
}

&:hover, &.activePage {
color: stencilColor("navPages-color-hover");
color: $navPage-subMenu-item--is-highlighted-color;

// scss-lint:disable NestingDepth
svg {
fill: stencilColor("navPages-color-hover");
stroke: stencilColor("navPages-color-hover");
fill: $navPage-subMenu-item--is-highlighted-color;
stroke: $navPage-subMenu-item--is-highlighted-color;
}
}

Expand Down Expand Up @@ -403,14 +406,6 @@
padding-right: spacing("single");
width: 100%;
}

.navPage-subMenu-action.is-open,
.navPage-subMenu-action:hover {
background: $navPage-subMenu-item--is-highlighted-background;
color: $navPage-subMenu-item--is-highlighted-color;
font-weight: 500;
opacity: 0.3;
}
}
}

Expand Down
4 changes: 2 additions & 2 deletions assets/scss/settings/stencil/navPages/_settings.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ $navPage-childList-borderColor: $navPage-borderColor;
$navPage-subMenu-horizontal-backgroundColor: stencilColor("navPages-subMenu-backgroundColor");
$navPage-subMenu-horizontal-height: auto;
$navPage-subMenu-horizontal-width: rem-calc(215px);
$navPage-subMenu-item--is-highlighted-background: #c8bdb2;
$navPage-subMenu-item--is-highlighted-color: #000;
$navPage-subMenu-item--is-highlighted-background: stencilColor("navPages-subMenu-backgroundColor");
$navPage-subMenu-item--is-highlighted-color: stencilColor("navPages-color-hover");
$navPages-action-moreIcon-borderColor: #d6cdc0;
$navPages-backgroundColor: stencilColor("navPages-subMenu-backgroundColor");
$navPages-list--user-borderColor: $navPage-borderColor;