Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-379 fix non-text contrast on add to cart button #1946

Merged
merged 2 commits into from
Jan 18, 2021
Merged

fix(storefront): BCTHEME-379 fix non-text contrast on add to cart button #1946

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5cb3b
fix(storefront): BCTHEME-379 fix non-text contrast on add to cart button
bc-alexsaiannyi Jan 13, 2021
fd08ac1
Merge branch 'master' into bctheme-379
bc-alexsaiannyi Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed non-text contrast on add to cart modal according to WCAG AA standard. [#1946](https://github.com/bigcommerce/cornerstone/pull/1946)
- Carousel buttons do not receive focus. [#1937](https://github.com/bigcommerce/cornerstone/pull/1937)
- Empty cart message not read by screen reader. [#1935](https://github.com/bigcommerce/cornerstone/pull/1935)
- No tooltips provided for carousel buttons. [#1934](https://github.com/bigcommerce/cornerstone/pull/1934)
Expand Down
2 changes: 1 addition & 1 deletion assets/scss/tools/_theme_focus.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

$outline-width: 2px;
$outline-style: solid;
$outline-color: #2E8FFF;
$outline-color: #0F7FFF;
$outline-offset: 1px;

input,
Expand Down