Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-401 Category pages are creating alt attribute within the span tag #1987

Merged
merged 2 commits into from
Feb 17, 2021
Merged

fix(storefront): BCTHEME-401 Category pages are creating alt attribute within the span tag #1987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c0fb87
fix(storefront): BCTHEME-401 Category pages are creating alt attribut…
yurytut1993 Feb 14, 2021
d1e2f9d
Merge branch 'master' into BCTHEME-401
yurytut1993 Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Category pages are creating alt attribute within the span tag. [1987](https://github.com/bigcommerce/cornerstone/pull/1987)
- Add alt attribute for no image placeholders. [#1984](https://github.com/bigcommerce/cornerstone/pull/1984)
- For non-required options, when the "None" option displays on the storefront it should be deselected when another option is chosen. [#1980](https://github.com/bigcommerce/cornerstone/pull/1980)
- Error message not announced automatically. [#1983](https://github.com/bigcommerce/cornerstone/pull/1983)
Expand Down
3 changes: 1 addition & 2 deletions templates/components/amp/products/ratings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<span role="img"
alt="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}"
title="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}"
aria-label="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}"
BC-tymurbiedukhin marked this conversation as resolved.
Show resolved Hide resolved
>
{{#for 1 5}}
{{#if ../this.rating '>=' $index}}
Expand Down
3 changes: 1 addition & 2 deletions templates/components/products/ratings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<span role="img"
alt="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}"
title="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}"
aria-label="{{lang 'products.reviews.rating_aria_label' current_rating=rating max_rating=5}}"
>
{{#for 1 5}}
{{#if ../this.rating '>=' $index}}
Expand Down