Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-362 fix cut off cart button on zooming 400 #1988

Merged
merged 2 commits into from
Feb 17, 2021
Merged

fix(storefront): BCTHEME-362 fix cut off cart button on zooming 400 #1988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321086f
fix(storefront): BCTHEME-362 fix cut off cart button on zooming 400
bc-alexsaiannyi Feb 16, 2021
9ce9615
Merge branch 'master' into bctheme-362
bc-alexsaiannyi Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Fixed cut off on Cart button when Zooming up to 400%. [#1988](https://github.com/bigcommerce/cornerstone/pull/1988)
- Category pages are creating alt attribute within the span tag. [1987](https://github.com/bigcommerce/cornerstone/pull/1987)
- Add alt attribute for no image placeholders. [#1984](https://github.com/bigcommerce/cornerstone/pull/1984)
- For non-required options, when the "None" option displays on the storefront it should be deselected when another option is chosen. [#1980](https://github.com/bigcommerce/cornerstone/pull/1980)
Expand Down
19 changes: 18 additions & 1 deletion assets/scss/components/stencil/cart/_cart.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,16 @@ $card-preview-zoom-bottom-offset: 6rem;
}

@include lazy-loaded-padding('productthumb_size');

&:after {
@include breakpoint("xxsmall") {
padding-bottom: 75%;
}

@include breakpoint("xsmall") {
padding-bottom: 100%;
}
}
}

.previewCartItem-content {
Expand Down Expand Up @@ -640,7 +650,14 @@ $card-preview-zoom-bottom-offset: 6rem;
@include grid-row;
border-top: container("border");
display: block;
padding: spacing("single") spacing("half");

@include breakpoint("xxsmall") {
padding: spacing("half") spacing("quarter");
}

@include breakpoint("xsmall") {
padding: spacing("single") spacing("half");
}

.button {
margin: 0;
Expand Down