Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storefront): BCTHEME-445 replace page builder ssl settings with new global region for html widget #2026

Merged
merged 2 commits into from
Apr 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Replace SSL settings in Page builder with global region for SSL certificate. [#2026](https://github.com/bigcommerce/cornerstone/pull/2026)
- fixed email address validation in forms. [#2029](https://github.com/bigcommerce/cornerstone/pull/2029)
- Fixed unnecessary horizontal scroll on swatch options on PDP. [#2023](https://github.com/bigcommerce/cornerstone/pull/2023)
- Always showing product counts for Category facet in the faceted search results page. [#2035](https://github.com/bigcommerce/cornerstone/pull/2035)
Expand Down
2 changes: 0 additions & 2 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,6 @@
"swatch_option_size": "22x22",
"social_icon_placement_top": false,
"social_icon_placement_bottom": "bottom_none",
"geotrust_ssl_common_name": "",
"geotrust_ssl_seal_size": "M",
"navigation_design": "simple",
"price_ranges": true,
"pdp-price-label": "",
Expand Down
30 changes: 0 additions & 30 deletions schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -938,36 +938,6 @@
"label": "i18n.ShowKlarna",
"force_reload": true,
"id": "show_accept_klarna"
},
{
"type": "heading",
"content": "i18n.GeoTrustSSL"
},
{
"type": "paragraph",
"content": "i18n.IfYouvePurchasedAGeoTrust"
},
{
"type": "text",
"label": "i18n.SSLCommonName",
"force_reload": true,
"id": "geotrust_ssl_common_name"
},
{
"type": "select",
"label": "i18n.SealSize",
"id": "geotrust_ssl_seal_size",
"options": [
{
"value": "M",
"label": "i18n.Medium"
},
{
"value": "S",
"label": "i18n.Small"
}
],
"force_reload": true
}
]
},
Expand Down
28 changes: 0 additions & 28 deletions schemaTranslations.json
Original file line number Diff line number Diff line change
Expand Up @@ -866,34 +866,6 @@
"uk": "Показати Klarna",
"zh": "显示 Klarna"
},
"i18n.GeoTrustSSL": {
"default": "GeoTrust SSL",
"fr": "SSL GeoTrust",
"it": "GeoTrust SSL",
"uk": "GeoTrust SSL",
"zh": "Geo信任SSL"
},
"i18n.IfYouvePurchasedAGeoTrust": {
"default": "If you've purchased a GeoTrust SSL from BigCommerce, check your BigCommerce Account Dashboard for the correct Common Name to use here.",
"fr": "Si vous avez acheté un SSL GeoTrust auprès de BigCommerce, consultez le tableau de bord de votre compte BigCommerce pour le nom commun correct à utiliser ici.",
"it": "Sei hai acquistato un SSL GeoTrust da BigCommerce, verifica sulla Dashboard del tuo Account BigCommerce il corretto Nome Comune da utilizzare qui.",
"uk": "Якщо ви придбали GeoTrust SSL у BigCommerce, перевірте на панелі керування облікового запису BigCommerce правильну загальну назву, яку тут можна використовувати.",
"zh": "如果您有在Bigcommerce中购买Geo信任SSL,检查您的Bigcommerce账户的控制面板,获得在这里使用的正确的公共名称。"
},
"i18n.SSLCommonName": {
"default": "SSL Common Name",
"fr": "Nom commun du SSL",
"it": "Nome Comune SSL",
"uk": "Загальна назва SSL",
"zh": "SSL公共名称"
},
"i18n.SealSize": {
"default": "Seal size",
"fr": "Taille du sceau",
"it": "Dimensioni sigillo",
"uk": "Розмір печатки",
"zh": "标志尺寸"
},
"i18n.Medium": {
"default": "Medium",
"fr": "Moyen",
Expand Down
6 changes: 1 addition & 5 deletions templates/components/common/footer.html
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ <h3 class="footer-info-heading">{{lang 'footer.info'}}</h3>
{{> components/common/payment-icons}}
</article>
</section>
{{#if theme_settings.geotrust_ssl_common_name}}
<div class="footer-geotrust-ssl-seal">
{{> components/common/geotrust-ssl-seal}}
</div>
{{/if}}
{{#if settings.paypal_commerce_credit_message}}
<div class="footer-copyright">
<p class="paypal-credit">{{nl2br settings.paypal_commerce_credit_message}}</p>
Expand All @@ -108,4 +103,5 @@ <h3 class="footer-info-heading">{{lang 'footer.info'}}</h3>
</div>
{{/if}}
</div>
{{{region name="ssl_site_seal--global"}}}
</footer>