Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-507 Translation Gap: Account -> Wish List -> Name required message. #2060

Merged
merged 2 commits into from
Jun 3, 2021
Merged

fix(storefront): BCTHEME-507 Translation Gap: Account -> Wish List -> Name required message. #2060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb25d40
fix(storefront): BCTHEME-507 Translation Gap: Account -> Wish List ->…
May 18, 2021
a350003
Merge branch 'master' into BCTHEME-507
BC-tymurbiedukhin Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Translation Gap: Account -> Wish List -> Name required message. [#2060](https://github.com/bigcommerce/cornerstone/pull/2060)
- Translation Gap: Cart -> Shipping estimator error messages. [#2066](https://github.com/bigcommerce/cornerstone/pull/2066)
- Add to cart button and Wishlist should be on one line on desktop. [#2050](https://github.com/bigcommerce/cornerstone/pull/2050)
- Logo on AMP Product details page (PDP) doesn't fit header. [#2054](https://github.com/bigcommerce/cornerstone/pull/2054)
Expand Down
2 changes: 1 addition & 1 deletion assets/js/theme/wishlist.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default class WishList extends PageManager {

cb(result);
},
errorMessage: 'You must enter a wishlist name.',
errorMessage: this.context.enterWishlistNameError,
},
]);

Expand Down
3 changes: 2 additions & 1 deletion lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,8 @@
"save": "Save Wish List",
"delete_alert": "Are you sure you want to delete your Wish List(s)? This action cannot be undone.",
"create_new": "Create New Wish List",
"add_to_default": "Add to My Wish List"
"add_to_default": "Add to My Wish List",
"enter_wishlist_name_error": "You must enter a wishlist name."
}
},
"page": {
Expand Down
2 changes: 2 additions & 0 deletions templates/components/account/add-wishlist.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{{inject 'enterWishlistNameError' (lang 'account.wishlists.enter_wishlist_name_error')}}

<div class="wishlist-add">
<header class="wishlist-header">
{{#if forms.wishlist.id}}
Expand Down