-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storefront): BCTHEME-608 Translation mechanism for config.json values should be implemented #2076
feat(storefront): BCTHEME-608 Translation mechanism for config.json values should be implemented #2076
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
{{inject "isProductListPresented" true}} | ||
|
||
<ul class="productList"> | ||
{{#each products}} | ||
<li class="product"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
{{inject "isProductCardPresented" true}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should add the same flag to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since it used only in scope of list I prefer to leave as it is |
||
|
||
<article | ||
class="card | ||
{{#if alternate}} card--alternate{{/if}}" | ||
|
@@ -29,13 +31,17 @@ | |
badge-type='sold-out' | ||
badge_view=theme_settings.product_sold_out_badges | ||
badge_label=theme_settings.pdp_sold_out_label | ||
page_builder_key="pdp_sold_out_label" | ||
default_translation=(lang "page_builder.pdp_sold_out_label") | ||
}} | ||
{{else}} | ||
{{#or price.sale_price_with_tax.value price.sale_price_without_tax.value}} | ||
{{> components/products/product-badge | ||
badge-type='sale' | ||
badge_view=theme_settings.product_sale_badges | ||
badge_label=theme_settings.pdp_sale_badge_label | ||
page_builder_key="pdp_sale_badge_label" | ||
default_translation=(lang "page_builder.pdp_sale_badge_label") | ||
}} | ||
{{/or}} | ||
{{/if}} | ||
|
@@ -105,7 +111,10 @@ | |
<h3 class="card-title"> | ||
<a aria-label="{{name}},{{> components/products/product-aria-label}}" | ||
href="{{url}}" | ||
{{#if settings.data_tag_enabled}} data-event-type="product-click" {{/if}}>{{name}}</a> | ||
{{#if settings.data_tag_enabled}}data-event-type="product-click"{{/if}} | ||
> | ||
{{name}} | ||
</a> | ||
</h3> | ||
|
||
<div class="card-text" data-test-info-type="price"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
{{inject "isProductListPresented" true}} | ||
|
||
<ul class="productList"> | ||
{{#each products}} | ||
<li class="product"> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it will be better to change
itemDefaultTranslation
toJsonTranslation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a taste thing, I prefer to use itemDefaultTranslation