Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-511 Remove counter on the Wish Lists tab on Account page #2087

Merged
merged 3 commits into from
Jul 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Counter on the Wish Lists tab on Account page has been removed. [#2087](https://github.com/bigcommerce/cornerstone/pull/2087)
- User Account, bug styles in section payment methods. [#2085](https://github.com/bigcommerce/cornerstone/pull/2085)
- Scss lint has been replaced with stylelint. [#2069](https://github.com/bigcommerce/cornerstone/pull/2069)

Expand Down
2 changes: 1 addition & 1 deletion lang/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Bestellungen",
"returns": "Rückgaben",
"messages": "Nachrichten ({num_new_messages})",
"wishlists": "Wunschlisten ({num_wishlists})",
"wishlists": "Wunschlisten",
"recently_viewed": "Kürzlich angesehen",
"settings": "Kontoeinstellungen",
"addresses": "Adressen",
Expand Down
2 changes: 1 addition & 1 deletion lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Orders",
"returns": "Returns",
"messages": "Messages ({num_new_messages})",
"wishlists": "Wish Lists ({num_wishlists})",
"wishlists": "Wish Lists",
"recently_viewed": "Recently Viewed",
"settings": "Account Settings",
"addresses": "Addresses",
Expand Down
2 changes: 1 addition & 1 deletion lang/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@
"orders": "Pedidos",
"returns": "Devoluciones",
"messages": "Mensajes ({num_new_messages})",
"wishlists": "Listas de deseos ({num_wishlists})",
"wishlists": "Listas de deseos",
"recently_viewed": "Vistos recientemente",
"settings": "Configuración de la cuenta",
"addresses": "Direcciones",
Expand Down
2 changes: 1 addition & 1 deletion lang/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Commandes",
"returns": "Retours",
"messages": "Messages ({num_new_messages})",
"wishlists": "Listes d'envies ({num_wishlists})",
"wishlists": "Listes d'envies",
"recently_viewed": "Consultés récemment",
"settings": "Paramètres de compte",
"addresses": "Adresses",
Expand Down
2 changes: 1 addition & 1 deletion lang/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Ordini",
"returns": "Resi",
"messages": "Messaggi ({num_new_messages})",
"wishlists": "Lista desideri ({num_wishlists})",
"wishlists": "Lista desideri",
"recently_viewed": "Visualizzati di recente",
"settings": "Impostazioni account",
"addresses": "Indirizzi",
Expand Down
2 changes: 1 addition & 1 deletion lang/nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Bestellingen",
"returns": "Retourzendingen",
"messages": "Berichten ({num_new_messages})",
"wishlists": "Verlanglijstjes ({num_wishlists})",
"wishlists": "Verlanglijstjes",
"recently_viewed": "Recent weergegeven",
"settings": "Accountinstellingen",
"addresses": "Adressen",
Expand Down
2 changes: 1 addition & 1 deletion lang/pt-BR.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Pedidos",
"returns": "Devoluções",
"messages": "Mensagens ({num_new_messages})",
"wishlists": "Listas de desejos ({num_wishlists})",
"wishlists": "Listas de desejos",
"recently_viewed": "Visto recentemente",
"settings": "Configurações da conta",
"addresses": "Endereços",
Expand Down
2 changes: 1 addition & 1 deletion lang/pt.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Pedidos",
"returns": "Devoluções",
"messages": "Mensagens ({num_new_messages})",
"wishlists": "Listas de desejos ({num_wishlists})",
"wishlists": "Listas de desejos",
"recently_viewed": "Visto recentemente",
"settings": "Configurações da conta",
"addresses": "Endereços",
Expand Down
2 changes: 1 addition & 1 deletion lang/sv.json
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@
"orders": "Beställningar",
"returns": "Returnerar",
"messages": "Meddelanden ({num_new_messages})",
"wishlists": "Önskelistor ({num_wishlists})",
"wishlists": "Önskelistor",
"recently_viewed": "Nyss sedda",
"settings": "Kontoinställningar",
"addresses": "Adresser",
Expand Down
4 changes: 2 additions & 2 deletions templates/components/account/navigation.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
{{/if}}
{{#if settings.show_wishlist}}
{{#if account_page '===' 'wishlists'}}
<li class="navBar-item is-active">{{lang 'account.nav.wishlists' num_wishlists=customer.num_wishlists}}</li>
<li class="navBar-item is-active">{{lang 'account.nav.wishlists'}}</li>
{{else}}
<li class="navBar-item">
<a class="navBar-action" href="{{urls.account.wishlists.all}}">{{lang 'account.nav.wishlists' num_wishlists=customer.num_wishlists}}</a>
<a class="navBar-action" href="{{urls.account.wishlists.all}}">{{lang 'account.nav.wishlists'}}</a>
</li>
{{/if}}
{{/if}}
Expand Down