fix(storefront): BCTHEME-1093 Make screen reader say all errors on me… #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-yevhenii-buliuk
approved these changes
Jul 19, 2022
BC-krasnoshapka
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssage page
Watching - #2235 - before moving forward
What?
When submitting the message form, each error should be read by the screen reader and again if tabbing back to the field.
Requirements
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Before - notice the messages are read too quickly at 0:09-0:11
before-BCTHEME-1093.mp4
After
after-click-BCTHEME-1093.mp4.mp4
after-tab-BCTHEME-1093.mp4