Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storefront): STRF-9829 Migrate Cornerstone to new "Hide Price From Guests" functionality #2262

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

jordanarldt
Copy link
Contributor

@jordanarldt jordanarldt commented Sep 13, 2022

Jira: STRF-9829

What?

This PR will remove the "restrict_to_login" theme configuration and replace it with the server-side "hide_price_from_guests" setting. This functionality is hidden behind the Feature_HidePriceFromGuestsSetting feature flag, so we will need coordination when this will be released in a new Cornerstone update on the marketplace.

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Channel Storefront Setting:
image

Product Cards:
image

Product Page:
image

Cart Page (if user creates cart while logged in and then logs out):
image

ping @bigcommerce/themes-team

templates/components/cart/content.html Show resolved Hide resolved
templates/components/cart/content.html Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jordanarldt jordanarldt reopened this Sep 16, 2022
@jordanarldt jordanarldt merged commit 26db3c7 into bigcommerce:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants