Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefont): BCTHEME-34 refactor svg attributes #2322

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix(storefont): BCTHEME-34 refactor svg attributes #2322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Draft
- Remove xlink attributes on svg [#2322](https://github.com/bigcommerce/cornerstone/pull/2322)

## 6.8.0 (01-26-2023)
- Add remote_api_scripts into cart/preview template to let GA3 snippet to fire the Product Added event, when clicking Add to cart button on Product detail page and rendering the response in popup. [#2281](https://github.com/bigcommerce/cornerstone/pull/2281)
Expand Down
2 changes: 1 addition & 1 deletion templates/components/account/order-contents.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ <h5 class="account-listShipping-title">{{lang 'account.orders.details.ship_to_mu
<span class="is-srOnly">{{lang 'account.orders.details.download_items'}}</span>
<span class="icon">
<svg>
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-arrow-down"></use>
<use href="#icon-arrow-down"></use>
</svg>
</span>
</a>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/account/payment-methods-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ <h4 class="paymentMethodsTitle">
{{/if}}
{{#if is_default}}
<svg class="methodHeader-default">
<use xlink:href="#icon-star" />
<use href="#icon-star" />
</svg>
{{/if}}
</div>
Expand Down
6 changes: 3 additions & 3 deletions templates/components/cart/content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ <h2 class="cart-item-name">
data-action="dec"
>
<span class="is-srOnly">{{lang 'products.quantity_decrease' name=name}}</span>
<i class="icon" aria-hidden="true"><svg><use xlink:href="#icon-keyboard-arrow-down" /></svg></i>
<i class="icon" aria-hidden="true"><svg><use href="#icon-keyboard-arrow-down" /></svg></i>
</button>
{{/if}}
<input class="form-input form-input--incrementTotal cart-item-qty-input"
Expand All @@ -131,7 +131,7 @@ <h2 class="cart-item-name">
data-action="inc"
>
<span class="is-srOnly">{{lang 'products.quantity_increase' name=name}}</span>
<i class="icon" aria-hidden="true"><svg><use xlink:href="#icon-keyboard-arrow-up" /></svg></i>
<i class="icon" aria-hidden="true"><svg><use href="#icon-keyboard-arrow-up" /></svg></i>
</button>
{{/if}}
</div>
Expand All @@ -154,7 +154,7 @@ <h2 class="cart-item-name">
data-confirm-delete="{{lang 'cart.confirm_delete'}}"
aria-label="{{lang 'cart.remove_item' name=name}}"
>
<svg><use xlink:href="#icon-close"></use></svg>
<svg><use href="#icon-close"></use></svg>
</button>
{{/or}}
</td>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/common/currency-selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
{{lang 'common.currency' code=currency_selector.active_currency_code}}
<i class="icon" aria-hidden="true">
<svg>
<use xlink:href="#icon-chevron-down" />
<use href="#icon-chevron-down" />
</svg>
</i>
</a>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/common/navigation-dropdown.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<li class="navPage-subMenu-item-child">
{{#if children}}
<a class="navPage-subMenu-action navPages-action navPages-action-depth-max has-subMenu{{#if is_active}} activePage{{/if}}" href="{{url}}" data-collapsible="navPages-{{id}}">
{{name}}<i class="icon navPages-action-moreIcon" aria-hidden="true"><svg><use xlink:href="#icon-chevron-down" /></svg></i>
{{name}}<i class="icon navPages-action-moreIcon" aria-hidden="true"><svg><use href="#icon-chevron-down" /></svg></i>
</a>
{{> components/common/navigation-dropdown}}
{{else}}
Expand Down
2 changes: 1 addition & 1 deletion templates/components/common/navigation-list-alternate.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
>
{{name}}
<i class="icon navPages-action-moreIcon" aria-hidden="true">
<svg><use xlink:href="#icon-chevron-down" /></svg>
<svg><use href="#icon-chevron-down" /></svg>
</i>
</a>
{{> components/common/navigation-dropdown}}
Expand Down
4 changes: 2 additions & 2 deletions templates/components/common/navigation-list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
>
{{name}}
<i class="icon navPages-action-moreIcon" aria-hidden="true">
<svg><use xlink:href="#icon-chevron-down" /></svg>
<svg><use href="#icon-chevron-down" /></svg>
</i>
</a>
<div class="navPage-subMenu" id="navPages-{{id}}" aria-hidden="true" tabindex="-1">
Expand Down Expand Up @@ -33,7 +33,7 @@
data-collapsible-enabled-state="closed"
>
<i class="icon navPages-action-moreIcon" aria-hidden="true">
<svg><use xlink:href="#icon-chevron-down" /></svg>
<svg><use href="#icon-chevron-down" /></svg>
</i>
</span>
</a>
Expand Down
4 changes: 2 additions & 2 deletions templates/components/common/navigation-menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
{{lang 'common.currency' code=currency_selector.active_currency_code}}
<i class="icon navPages-action-moreIcon" aria-hidden="true">
<svg>
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-chevron-down"></use>
<use href="#icon-chevron-down"></use>
</svg>
</i>
</a>
Expand Down Expand Up @@ -106,7 +106,7 @@
>
{{lang 'common.account'}}
<i class="icon navPages-action-moreIcon" aria-hidden="true">
<svg><use xlink:href="#icon-chevron-down" /></svg>
<svg><use href="#icon-chevron-down" /></svg>
</i>
</a>
<div class="navPage-subMenu" id="navPages-account" aria-hidden="true" tabindex="-1">
Expand Down
4 changes: 2 additions & 2 deletions templates/components/common/paginator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
>
<i class="icon" aria-hidden="true">
<svg>
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-chevron-left"></use>
<use href="#icon-chevron-left"></use>
</svg>
</i>
{{lang 'common.previous'}}
Expand Down Expand Up @@ -42,7 +42,7 @@
{{lang 'common.next'}}
<i class="icon" aria-hidden="true">
<svg>
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-chevron-right"></use>
<use href="#icon-chevron-right"></use>
</svg>
</i>
</a>
Expand Down
16 changes: 8 additions & 8 deletions templates/components/common/payment-icons.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,28 @@
{{#or show_accept_amex show_accept_discover show_accept_mastercard show_accept_paypal show_accept_visa show_accept_amazonpay show_accept_googlepay show_accept_klarna}}
<div class="footer-payment-icons">
{{#if show_accept_amex}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-american-express"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-american-express"></use></svg>
{{/if}}
{{#if show_accept_discover}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-discover"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-discover"></use></svg>
{{/if}}
{{#if show_accept_mastercard}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-mastercard"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-mastercard"></use></svg>
{{/if}}
{{#if show_accept_paypal}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-paypal"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-paypal"></use></svg>
{{/if}}
{{#if show_accept_visa}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-visa"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-visa"></use></svg>
{{/if}}
{{#if show_accept_amazonpay}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-amazonpay"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-amazonpay"></use></svg>
{{/if}}
{{#if show_accept_googlepay}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-googlepay"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-googlepay"></use></svg>
{{/if}}
{{#if show_accept_klarna}}
<svg class="footer-payment-icon"><use xlink:href="#icon-logo-klarna"></use></svg>
<svg class="footer-payment-icon"><use href="#icon-logo-klarna"></use></svg>
{{/if}}
</div>
{{/or}}
Expand Down
12 changes: 6 additions & 6 deletions templates/components/common/share.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
>
<span class="aria-description--hidden">{{{capitalize service}}}</span>
<svg>
<use xlink:href="#icon-facebook"/>
<use href="#icon-facebook"/>
</svg>
</a>
{{else if service '===' 'email'}}
Expand All @@ -28,7 +28,7 @@
>
<span class="aria-description--hidden">{{{capitalize service}}}</span>
<svg>
<use xlink:href="#icon-envelope"/>
<use href="#icon-envelope"/>
</svg>
</a>
{{else if service '===' 'print'}}
Expand All @@ -39,7 +39,7 @@
>
<span class="aria-description--hidden">{{{capitalize service}}}</span>
<svg>
<use xlink:href="#icon-print"/>
<use href="#icon-print"/>
</svg>
</a>
{{else if service '===' 'twitter'}}
Expand All @@ -52,7 +52,7 @@
>
<span class="aria-description--hidden">{{{capitalize service}}}</span>
<svg>
<use xlink:href="#icon-twitter"/>
<use href="#icon-twitter"/>
</svg>
</a>
{{else if service '===' 'linkedin'}}
Expand All @@ -65,7 +65,7 @@
>
<span class="aria-description--hidden">{{{capitalize service}}}</span>
<svg>
<use xlink:href="#icon-linkedin"/>
<use href="#icon-linkedin"/>
</svg>
</a>
{{else if service '===' 'pinterest'}}
Expand All @@ -78,7 +78,7 @@
>
<span class="aria-description--hidden">{{{capitalize service}}}</span>
<svg>
<use xlink:href="#icon-pinterest"/>
<use href="#icon-pinterest"/>
</svg>
</a>
{{/if}}
Expand Down
4 changes: 2 additions & 2 deletions templates/components/common/small-paginator.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<a class="pagination-link" href="{{previous}}" data-faceted-search-facet>
<i class="icon" aria-hidden="true">
<svg>
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-chevron-left"></use>
<use href="#icon-chevron-left"></use>
</svg>
</i>
{{lang 'common.previous'}}
Expand All @@ -27,7 +27,7 @@
{{lang 'common.next'}}
<i class="icon" aria-hidden="true">
<svg>
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-chevron-right"></use>
<use href="#icon-chevron-right"></use>
</svg>
</i>
</a>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/common/social-links.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
>
<span class="aria-description--hidden">{{{capitalize display_name}}}</span>
<svg>
<use xlink:href="#icon-{{display_name}}"/>
<use href="#icon-{{display_name}}"/>
</svg>
</a>
</li>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/common/wishlist-dropdown.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<span>{{lang 'account.wishlists.add_item'}}</span>
<i aria-hidden="true" class="icon">
<svg>
<use xlink:href="#icon-chevron-down" />
<use href="#icon-chevron-down" />
</svg>
</i>
</a>
Expand Down
4 changes: 2 additions & 2 deletions templates/components/faceted-search/faceted-search-navigation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@

<span>
<svg class="icon accordion-indicator toggleLink-text toggleLink-text--off">
<use xlink:href="#icon-add" />
<use href="#icon-add" />
</svg>
<svg class="icon accordion-indicator toggleLink-text toggleLink-text--on">
<use xlink:href="#icon-remove" />
<use href="#icon-remove" />
</svg>
</span>
</button>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/faceted-search/facets/multi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<span class="navList-action-close" aria-hidden="true">
<svg class="icon">
<use xlink:href="#icon-close"/>
<use href="#icon-close"/>
</svg>
</span>
</a>
Expand Down
4 changes: 2 additions & 2 deletions templates/components/faceted-search/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
{{lang 'search.faceted.hide-filters'}}

<i class="icon" aria-hidden="true">
<svg><use xlink:href="#icon-keyboard-arrow-up"/></svg>
<svg><use href="#icon-keyboard-arrow-up"/></svg>
</i>
</span>

<span class="toggleLink-text toggleLink-text--off">
{{lang 'search.faceted.show-filters'}}

<i class="icon" aria-hidden="true">
<svg><use xlink:href="#icon-keyboard-arrow-down"/></svg>
<svg><use href="#icon-keyboard-arrow-down"/></svg>
</i>
</span>
</span>
Expand Down
2 changes: 1 addition & 1 deletion templates/components/faceted-search/selected-facets.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ <h2 class="sidebarBlock-heading">
{{/if}}

<svg class="icon">
<use xlink:href="#icon-close" />
<use href="#icon-close" />
</svg>
</a>
</li>
Expand Down
6 changes: 3 additions & 3 deletions templates/components/products/add-to-cart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div id="add-to-cart-wrapper" class="add-to-cart-wrapper" {{#unless product.can_purchase}}style="display: none"{{/unless}}>
{{#if product.show_quantity_input}}
{{#if theme_settings.show_product_quantity_box}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bc-alexsaiannyi Was this change supposed to be reverted here? This change was made in Cornerstone 6.8

{{inject 'productQuantityErrorMessage' (lang 'products.quantity_error_message')}}
<div class="form-field form-field--increments">
<label class="form-label form-label--alternate"
Expand All @@ -9,7 +9,7 @@
<span class="is-srOnly">{{lang 'products.quantity_decrease' name=product.title}}</span>
<i class="icon" aria-hidden="true">
<svg>
<use xlink:href="#icon-keyboard-arrow-down"/>
<use href="#icon-keyboard-arrow-down"/>
</svg>
</i>
</button>
Expand All @@ -27,7 +27,7 @@
<span class="is-srOnly">{{lang 'products.quantity_increase' name=product.title}}</span>
<i class="icon" aria-hidden="true">
<svg>
<use xlink:href="#icon-keyboard-arrow-up"/>
<use href="#icon-keyboard-arrow-up"/>
</svg>
</i>
</button>
Expand Down
4 changes: 2 additions & 2 deletions templates/components/products/ratings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
{{#if ../this.rating '>=' $index}}
<span class="icon icon--ratingFull">
<svg>
<use xlink:href="#icon-star" />
<use href="#icon-star" />
</svg>
</span>
{{else}}
<span class="icon icon--ratingEmpty">
<svg>
<use xlink:href="#icon-star" />
<use href="#icon-star" />
</svg>
</span>
{{/if}}
Expand Down
4 changes: 2 additions & 2 deletions templates/pages/account/add-payment-method.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ <h3 class="paymentMethodForm-heading">{{lang 'account.payment_methods.payment_me
<div class="paymentMethodForm-inputs">
{{> components/common/forms/text id="credit_card_number" name="credit_card_number" label=(lang 'account.payment_methods.credit_card_number')}}
<svg class="paymentMethodForm-inputs-icon icon">
<use xlink:href="#icon-lock" />
<use href="#icon-lock" />
</svg>
</div>
<div class="paymentMethodForm-inputs">
Expand All @@ -79,7 +79,7 @@ <h3 class="paymentMethodForm-heading">{{lang 'account.payment_methods.payment_me
<div class="paymentMethodForm-inputs">
{{> components/common/forms/text id="cvv" name="cvv" label=(lang 'account.payment_methods.cvv')}}
<svg class="paymentMethodForm-inputs-icon icon">
<use xlink:href="#icon-lock" />
<use href="#icon-lock" />
</svg>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion templates/pages/compare.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ <h1 class="page-heading">{{lang 'compare.header' products=comparisons.length}}</
</a>
<a class="compareTable-removeProduct" data-comparison-remove href="{{#if remove_url}}{{remove_url}}{{else}}#{{/if}}">
<svg class="icon">
<use xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="#icon-close"></use>
<use href="#icon-close"></use>
</svg>
</a>
</figure>
Expand Down