fix: DATA-11867 Fix duplicating add_to_cart meta pixel events #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc-yevhenii-buliuk
approved these changes
May 24, 2024
bc-vlad-dlogush
approved these changes
May 27, 2024
solofeed
approved these changes
May 27, 2024
|
@bc-rmalyavc does the GA4 Add to Cart event still work? Previously, without this code, it did not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove
remote_api_scriptsfrom cart preview template which fixes duplicatingaddToCartevent for Meta Pixel integration.Previously we've added it to fix the legacy (UA) Google Analytics integration without realising it's duplicating Meta Pixel event. Since the legacy Google Analytics is sunset now, it's not a concern anymore, so it's safe to remove these scripts.
Requirements
Tickets / Documentation
DATA-11867
PR where the issue was initially introduced: #2281
Screenshots (if appropriate)
Testing
addToCartevent is firing now when I adding a product from PDP or QuickView product form