Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zoom in on main product image for mobile #2468

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dpschu2
Copy link
Contributor

@Dpschu2 Dpschu2 commented Jun 6, 2024

What?

Allow zoom in on main product image for mobile

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Attach images or add image links here.

Example Image

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented Jun 6, 2024

Ready for review

@BC-krasnoshapka BC-krasnoshapka requested a review from a team June 10, 2024 10:11
@BC-krasnoshapka
Copy link
Contributor

hi @Dpschu2 ,

Our CI build fails with npm install errors (see below). Does it work for you?

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: eslint-config-airbnb@19.0.4
npm ERR! Found: eslint@9.4.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.4.0" from the root project
npm ERR!   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm ERR!   node_modules/@eslint-community/eslint-utils
npm ERR!     @eslint-community/eslint-utils@"^4.2.0" from eslint@9.4.0
npm ERR!   1 more (babel-eslint)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^7.32.0 || ^8.2.0" from eslint-config-airbnb@19.0.4
npm ERR! node_modules/eslint-config-airbnb
npm ERR!   dev eslint-config-airbnb@"^19.0.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@8.[5](https://github.com/bigcommerce/cornerstone/pull/2468/checks#step:6:6)7.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^[7](https://github.com/bigcommerce/cornerstone/pull/2468/checks#step:6:8).32.0 || ^8.2.0" from eslint-config-airbnb@19.0.4
npm ERR!   node_modules/eslint-config-airbnb
npm ERR!     dev eslint-config-airbnb@"^1[9](https://github.com/bigcommerce/cornerstone/pull/2468/checks#step:6:10).0.4" from the root project

@bc-yevhenii-buliuk
Copy link
Contributor

bc-yevhenii-buliuk commented Jun 10, 2024

@Dpschu2 could you also add screenshots or video recordings that show the changes in the description of your PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants