Support Stencil CLI's ESM migration #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
force-pushed
the
support-esm-stencil-cli-changes
branch
from
2349980 to
c24ce5a
Compare
bc-alexsaiannyi
approved these changes
Nov 14, 2024
rtalvarez
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Latest stencil cli version (8.4.0) has migrated to ESM and requires now to have stencil.config.js as stencil.config.cjs.
This doesn't block user experience with stencil cli, but it moves renames the file if it doesn't exist. It might be annoying for the dev experience that this file appears in git.
Requirements
Tickets / Documentation
Screenshots (if appropriate)