Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storefront): SD-10884 add support Node 20 #2519

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

bc-alexsaiannyi
Copy link
Contributor

@bc-alexsaiannyi bc-alexsaiannyi commented Dec 11, 2024

What?

This PR brings support Node 20 for Cornerstone.

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Screenshots (if appropriate)

locally

image

@bc-alexsaiannyi bc-alexsaiannyi marked this pull request as ready for review December 12, 2024 14:44
Copy link
Member

@rtalvarez rtalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by any chance were you able to upload the theme to an existing store and just make sure the bundle works fine? i dont know whether this is a regular part of the testing process during bumping these versions but it might be a good idea to do so

@bc-alexsaiannyi
Copy link
Contributor Author

by any chance were you able to upload the theme to an existing store and just make sure the bundle works fine? i dont know whether this is a regular part of the testing process during bumping these versions but it might be a good idea to do so

Actually yes. I've created the bundle, applied to my Employee Store, and gone through main flow. I didn't see any errors there as well.

@bc-alexsaiannyi bc-alexsaiannyi merged commit 0188ef3 into bigcommerce:master Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants