Ignore query string for callback url #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philipmuir Any change you can possibly address immediately? This should render this gem unusable until deployed. |
|
@carsonreinke This is indeed a bug introduced by omniauth-oauth2. Thanks for submitting the fix. Please rebase on master and we'll merge it right away. Rebasing should fix the Travis failure as well. |
…e it for redirect_uri Adding coverage folder to .gitignore
|
Green, but oddly have .gitignore in there from my change. Let me know if you want me to mess around. |
|
👍 |
|
Thanks for the contribution. I have one more change I want to add, and then we'll cut a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently burned by this pretty bad. Updating to omniauth-oauth2 1.4.0, the callback url has now included the query string. BigCommerce services appears to also validate on this.
Some related information about this:
omniauth/omniauth-oauth2#82
omniauth/omniauth-oauth2#70