Skip to content

Commit

Permalink
feat: STRF-10366 Node 18 Support
Browse files Browse the repository at this point in the history
  • Loading branch information
jairo-bc committed Jan 20, 2023
1 parent aa0919b commit fdbac8f
Show file tree
Hide file tree
Showing 7 changed files with 49 additions and 62 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build:
strategy:
matrix:
node: [14.x]
node: [18.x]
os: ['ubuntu-latest', 'windows-2019', 'macos-latest']

runs-on: ${{ matrix.os }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '14.x'
node-version: '18.x'
- run: npm i
- name: Check Git Commit name
run: git log -1 --pretty=format:"%s" | npx commitlint
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14.19
v18.13
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:14
FROM node:18

WORKDIR /usr/src/app

Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ The BigCommerce server emulator for local theme development.

## Install

_Note: Stencil requires the Node.js runtime environment,
version 14.x is supported.
We do not yet have support for versions greater than Node 14._
Note: Stencil requires the Node.js runtime environment,
version 18.x is supported.

Run `npm install -g @bigcommerce/stencil-cli`.

Expand Down
94 changes: 41 additions & 53 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"description": "CLI tool to run BigCommerce Stores locally for theme development.",
"main": "index.js",
"engines": {
"node": ">=14.0.0 <15.0.0",
"npm": ">=v6.11.3 <9.0.0"
"node": ">=17.0.0 <19.0.0",
"npm": ">=8.0.0 <10.0.0"
},
"scripts": {
"lint": "eslint . && prettier --check . --ignore-unknown",
Expand Down

0 comments on commit fdbac8f

Please sign in to comment.