Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: STRF-11903 Migrate to ESM #1230

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: STRF-11903 Migrate to ESM #1230

merged 1 commit into from
Sep 24, 2024

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Sep 12, 2024 •
edited
Loading

What?

  • Used csjtoesm package to automate most of the changes of the imports.
  • jest adjustments to support ESM
  • reading from stencil.config.js will move the file into .cjs

Tickets / Documentation

Screenshots (if appropriate)

stencil start:
Screenshot 2024-09-12 at 11 57 32

stencil bundle:
Screenshot 2024-09-12 at 11 58 24

stencil pull:
Screenshot 2024-09-12 at 11 58 57

stencil push:
Screenshot 2024-09-12 at 12 02 05

stencil download:
Screenshot 2024-09-12 at 12 04 12

stencil release:
Screenshot 2024-09-12 at 14 15 00

stencil debug:
Screenshot 2024-09-12 at 12 04 24

cc @bigcommerce/storefront-team

@jairo-bc jairo-bc requested a review from a team September 16, 2024 09:37
@jairo-bc jairo-bc force-pushed the STRF-11903 branch 2 times, most recently from 2829a9c to 27b455e Compare September 23, 2024 10:25
jordanarldt
jordanarldt approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jordanarldt jordanarldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Went ahead and tested locally as well. Stencil CLI works exactly the same as before when running locally.

@jairo-bc jairo-bc merged commit 9e462ea into master Sep 24, 2024
12 checks passed
@jairo-bc jairo-bc mentioned this pull request Oct 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanarldt jordanarldt jordanarldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jairo-bc @jordanarldt