Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cp): STRF-5614 Add enhanced_ecommerce to theme config schema. #425

Merged
merged 1 commit into from
Nov 2, 2018
Merged

fix(cp): STRF-5614 Add enhanced_ecommerce to theme config schema. #425

merged 1 commit into from
Nov 2, 2018

Conversation

Ubersmake
Copy link
Contributor

What?

Add enhanced_ecommerce for theme config schema validation.

Links

lord2800
lord2800 approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@lord2800 lord2800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How in the world has this been working for us without this? 😦

@Ubersmake
Copy link
Contributor Author

FWIW, stencil bundle worked. I don't know how. It was publishing the theme that caused issues.

mattolson
mattolson reviewed Nov 2, 2018
View reviewed changes
Copy link
Contributor

@mattolson mattolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to bump the version number in package.json and update the changelog.

@mattolson mattolson merged commit d7d98f6 into bigcommerce:master Nov 2, 2018
@Ubersmake Ubersmake deleted the AddCornerstoneFeatures branch November 2, 2018 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lord2800 lord2800 lord2800 approved these changes

@mattolson mattolson mattolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ubersmake @mattolson @lord2800