feat(storefront): strf-9174 Product object in quick view on localhost not consistent with prod: #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not consistent with prod: -renderer.module - additional check for stencil-config added; - index - duplicate code removed; - package-lock.json - updated;
bc-max
commented
Sep 27, 2022
| @@ -33,8 +33,6 @@ function buildManifest(srcManifest, options) { | |||
| pluginsByName['./plugins/renderer/renderer.module'].storeUrl = storeUrl; | |||
| pluginsByName['./plugins/renderer/renderer.module'].storeSettingsLocale = | |||
| options.storeSettingsLocale; | |||
| pluginsByName['./plugins/renderer/renderer.module'].customLayouts = | |||
There was a problem hiding this comment.
this is duplicate of line 30 above
jairo-bc
reviewed
Sep 27, 2022
jairo-bc
reviewed
Sep 27, 2022
| if (!request.headers['stencil-config'] && stencilConfig) { | ||
| const config = request.headers['stencil-config']; | ||
|
|
||
| if ((!config || config === '{}') && stencilConfig) { |
There was a problem hiding this comment.
So the header can be undefined and can be empty object?
There was a problem hiding this comment.
Not sure about undefined, I decided not to touch existing check just not to break anything. However, it definitely could be empty object. I saw that during debugging.
… not consistent with prod: - package-lock.json - reverted;
bc-max
commented
Sep 27, 2022
… not consistent with prod: - package-lock.json - reverted;
jairo-bc
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Quick-view in stencil-cli mode didn't include
reviewssections if any.Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team