fix: STRF-8599 Passed down the target (current) element from the general subscribe event handlers #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ral subscribe event handlers
|
Autotagging @bigcommerce/storefront-team |
junedkazi
reviewed
Sep 4, 2020
| @@ -5,7 +5,7 @@ export default class extends EventEmitter { | |||
| document.addEventListener(eventName, function (e) { | |||
| for (let target = e.target; target && target !== this; target = target.parentNode) { | |||
| if (target.matches(elementSelector)) { | |||
| handler.call(target, e); | |||
| handler.call(target, e, target); | |||
There was a problem hiding this comment.
so we pass target 2 times now ?
There was a problem hiding this comment.
should the first argument be elementSelector ?
There was a problem hiding this comment.
first param is for binding this context
MaxGenash
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some elements on the cornerstone couldn't rely on the currentTarget from the event, because .subscribe() method adds event handler on the document. So the idea is to pass down through the eventemitter not only the event, but also the currentTarget element.