feat: STRF-12444 Suport Node 20, drop node 14, 16 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
force-pushed
the
STRF-12444
branch
2 times, most recently
from
8f76ee9 to
8dfe8a1
Compare
jairo-bc
force-pushed
the
STRF-12444
branch
from
8dfe8a1 to
d076964
Compare
jairo-bc
force-pushed
the
STRF-12444
branch
from
d076964 to
e420315
Compare
jmwiese
reviewed
Sep 24, 2024
| - name: Set npm registry | ||
| run: echo "@bigcommerce-labs:registry=https://npm.pkg.github.com/" >> ~/.npmrc | ||
| - name: Set npm secrets | ||
| run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.CUSTOM_GA_TOKEN }}" >> ~/.npmrc | ||
| run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.DEPENDABOT_GITHUB_TOKEN }}" >> ~/.npmrc |
There was a problem hiding this comment.
Have we set this in all relevant spots?
There was a problem hiding this comment.
now yes :)
I did it in another PR and didn't release
bc-raymond-kong
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: STRF-12444
What/Why?
Support Node 20, drop node 14, 16
Rollout/Rollback
Revert PR
Testing
unit tests