Reload page when we get a 401 back from bcapp #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwiese
commented
Oct 1, 2024
jmwiese
force-pushed
the
STRF-12520
branch
2 times, most recently
from
52380d6 to
c9e47fb
Compare
jairo-bc
reviewed
Oct 2, 2024
jmwiese
force-pushed
the
STRF-12520
branch
3 times, most recently
from
848cb3f to
28084bd
Compare
|
LGTM |
huntario
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
To test this I deployed the changes on https://github.com/bigcommerce/bigcommerce/pull/60205 and applied these changes on this PR to my copy of Cornerstone.
After waiting 5 minutes, I'm redirected to the preview code screen as expected.
Also tested the checkout process which completed successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: STRF-12520
What/Why?
Starting with this PR we are going to return a 401 Unauthorized response when an AJAX request is made against a preview storefront with an expired preview session.
This PR should trigger a page reload, which should land the user back on the preview code page to re-enter their code.
Rollout/Rollback
Revert this PR
Testing
Locally and in intg