Remove cookie API #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team |
|
This change fills me with so many feelings. 👏 😢 😠 |
|
Can you bump to 2.0? |
bookernath
force-pushed
the
remove-cookie-api
branch
from
00b5038 to
c20bc5d
Compare
bookernath
force-pushed
the
remove-cookie-api
branch
from
c20bc5d to
3a4f09d
Compare
mattolson
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cookie API is unnecessary; the essential piece of information it provides, which is "does the store have a certain setting enabled", can be determined from theme context.
Unfortunately, due to the nature of this API's constructor, this will be a breaking change for stencil-utils and necessitate a 2.0 version in order to update Cornerstone and other themes to avoid this request. (Cornerstone PR: bigcommerce/cornerstone#1380)
Fortunately, this will improve performance.