fix: duplicate closing files(OpenAtomFoundation#2304) (OpenAtomFounda…

…tion#2311) Co-authored-by: liuchengyu <liuchengyu@360.cn>
bigdaronlee163 · Jan 15, 2024 · 73dbcd6 · 73dbcd6
1 parent bf08a8f
commit 73dbcd6
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/rsync_client.cc b/src/rsync_client.cc
@@ -166,7 +166,7 @@ Status RsyncClient::CopyRemoteFile(const std::string& filename, int index) {
     while (retries < max_retries_) {
       if (state_.load() != RUNNING) {
         break;
-        }
+      }
       size_t copy_file_begin_time = pstd::NowMicros();
       size_t count = Throttle::GetInstance().ThrottledByThroughput(kBytesPerRequest);
       if (count == 0) {
@@ -227,12 +227,7 @@ Status RsyncClient::CopyRemoteFile(const std::string& filename, int index) {
         s = writer->Fsync();
         if (!s.ok()) {
             return s;
-        }
-        s = writer->Close();
-        if (!s.ok()) {
-            return s;
-        }
-        writer.reset();
+        } 
         mu_.lock();
         meta_table_[filename] = "";
         mu_.unlock();